Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nfr #1238 #1295

Merged
merged 2 commits into from
Sep 30, 2013
Merged

Fix nfr #1238 #1295

merged 2 commits into from
Sep 30, 2013

Conversation

dreamsxin
Copy link
Contributor

Fix nfr #1238

ghost
ghost reviewed Sep 26, 2013
View reviewed changes
ext/logger/adapter.c
*/
PHP_METHOD(Phalcon_Logger_Adapter, isTransaction){

RETURN_MEMBER(this_ptr, "_transaction");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But where is _transaction set?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sjinks Always had this property, just add a read method
See https://github.com/dreamsxin/cphalcon/blob/7d49a79fd733b5d1858f65fdfb1cd1de5fc729b9/ext/logger/adapter.c#L130

phalcon pushed a commit that referenced this pull request Sep 30, 2013
Merge pull request #1295 from dreamsxin/1238
38ed6f7 
Fix nfr #1238
@phalcon phalcon merged commit 38ed6f7 into phalcon:1.3.0 Sep 30, 2013
@dreamsxin dreamsxin deleted the 1238 branch August 20, 2014 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dreamsxin @phalcon